Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor clarification to pathObject #38437

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 27, 2021

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #36582

Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#36582
@github-actions github-actions bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Apr 27, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2021
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2021

Simple change that shouldn't need to wait the 48 hours to land. Fast-track? Please 👍🏻

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2021
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2021

Landed in 5a0ed51

@jasnell jasnell closed this Apr 27, 2021
jasnell added a commit that referenced this pull request Apr 27, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582

PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 29, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582

PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582

PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582

PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582

PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Jun 11, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #36582

PR-URL: #38437
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: Please explain what "pathObject" is
3 participants