-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix common.mustCall
length
and name
properties
#38464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Apr 29, 2021
jasnell
approved these changes
Apr 29, 2021
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 29, 2021
This comment has been minimized.
This comment has been minimized.
trivikr
approved these changes
Apr 30, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
added
fast-track
PRs that do not need to wait for 48 hours to land.
and removed
needs-ci
PRs that need a full CI run.
labels
Apr 30, 2021
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Trott
reviewed
May 2, 2021
Trott
approved these changes
May 2, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: nodejs#38464 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95
force-pushed
the
test-common-mustCall-length
branch
from
May 2, 2021 09:56
92b358a
to
5cee7cb
Compare
Landed in 5cee7cb |
targos
pushed a commit
that referenced
this pull request
May 3, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: #38464 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reassign
name
andlength
properties to the returned function to notbreak code that relies on it.
This is needed for #37947.