Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix common.mustCall length and name properties #38464

Merged
merged 1 commit into from
May 2, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 29, 2021

Reassign name and length properties to the returned function to not
break code that relies on it.

This is needed for #37947.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 29, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 30, 2021

@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels Apr 30, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label May 2, 2021
Reassign `name` and `length` properties to the returned function to not
break code that relies on it.

PR-URL: nodejs#38464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the test-common-mustCall-length branch from 92b358a to 5cee7cb Compare May 2, 2021 09:56
@aduh95
Copy link
Contributor Author

aduh95 commented May 2, 2021

Landed in 5cee7cb

@aduh95 aduh95 merged commit 5cee7cb into nodejs:master May 2, 2021
@aduh95 aduh95 deleted the test-common-mustCall-length branch May 2, 2021 09:58
targos pushed a commit that referenced this pull request May 3, 2021
Reassign `name` and `length` properties to the returned function to not
break code that relies on it.

PR-URL: #38464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 3, 2021
targos pushed a commit that referenced this pull request May 30, 2021
Reassign `name` and `length` properties to the returned function to not
break code that relies on it.

PR-URL: #38464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Reassign `name` and `length` properties to the returned function to not
break code that relies on it.

PR-URL: #38464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Reassign `name` and `length` properties to the returned function to not
break code that relies on it.

PR-URL: #38464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Reassign `name` and `length` properties to the returned function to not
break code that relies on it.

PR-URL: #38464
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants