Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update abort signal in fs promise api example #38669

Closed
wants to merge 5 commits into from
Closed

Update abort signal in fs promise api example #38669

wants to merge 5 commits into from

Commits on May 13, 2021

  1. Update abort signal in fs promise api example 

    Without `await`ing the promise the try-catch block would never catch this error. IMO this was misleading.
    @MoritzKn
    MoritzKn committed May 13, 2021
    Configuration menu
    Copy the full SHA
    a0e88ea View commit details
    Browse the repository at this point in the history

  2. Update doc/api/fs.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @MoritzKn @aduh95
    MoritzKn and aduh95 committed May 13, 2021
    Configuration menu
    Copy the full SHA
    69795ff View commit details
    Browse the repository at this point in the history

  3. Update doc/api/fs.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @MoritzKn @aduh95
    MoritzKn and aduh95 committed May 13, 2021
    Configuration menu
    Copy the full SHA
    b5ad79c View commit details
    Browse the repository at this point in the history

  4. Remove trailing spaces

    @MoritzKn
    MoritzKn committed May 13, 2021
    Configuration menu
    Copy the full SHA
    584a227 View commit details
    Browse the repository at this point in the history

  5. Update doc/api/fs.md 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @MoritzKn @aduh95
    MoritzKn and aduh95 committed May 13, 2021
    Configuration menu
    Copy the full SHA
    682a00e View commit details
    Browse the repository at this point in the history