test: fix writefile with fd #38820
Closed
test: fix writefile with fd #38820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix writefile with fd so that it'll close the fds that is uses during the test.
github-actions
bot
added
needs-ci
richardlau
reviewed
May 26, 2021
What I did was definitely wrong for the sync write, as if one of those asserts fails I would miss registering the beforeExit. For the other paths - I think that its simpler to push the fds into an array, because everything is async and I would need to make sure that all of the paths are covered. |
Linkgoron
force-pushed
the
fs-fix-writefile-with-fd
branch
from
3e3264c
to
280e745
Compare
benjamingr
approved these changes
May 27, 2021
Linkgoron
added
the
author ready
RaisinTen
approved these changes
May 27, 2021
|
Fast-track has been requested by @targos. Please 👍 to approve. |
targos
pushed a commit
that referenced
this pull request
May 28, 2021
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: #38820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
|
Landed in 0222a10 |
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: #38820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: #38820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: #38820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: #38820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
fix writefile with fd so that it'll close the fds that is uses during the test. PR-URL: nodejs#38820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix writefile with fd so that it'll close the fds that it uses during the test, as it breaks the build on Windows, after #38684