Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update setup-node@v1 to setup-node@v2 #38825

Closed
wants to merge 1 commit into from
Closed

tools: update setup-node@v1 to setup-node@v2 #38825

wants to merge 1 commit into from

Conversation

JayFate
Copy link
Contributor

@JayFate JayFate commented May 27, 2021

update setup-node@v1 to setup-node@v2.

Signed-off-by: pengjie 37610029@qq.com

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 27, 2021
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @richardlau's comment addressed.

Signed-off-by: pengjie <37610029@qq.com>
gengjiawen pushed a commit that referenced this pull request May 29, 2021
Signed-off-by: pengjie <37610029@qq.com>

PR-URL: #38825
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@gengjiawen
Copy link
Member

Landed in 4c508f5.

Thanks for the contribution :)

@gengjiawen gengjiawen closed this May 29, 2021
danielleadams pushed a commit that referenced this pull request May 31, 2021
Signed-off-by: pengjie <37610029@qq.com>

PR-URL: #38825
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
richardlau pushed a commit that referenced this pull request Jul 16, 2021
Signed-off-by: pengjie <37610029@qq.com>

PR-URL: #38825
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
Signed-off-by: pengjie <37610029@qq.com>

PR-URL: #38825
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
Signed-off-by: pengjie <37610029@qq.com>

PR-URL: #38825
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Signed-off-by: pengjie <37610029@qq.com>

PR-URL: nodejs#38825
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants