-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update setup-node@v1 to setup-node@v2 #38825
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build
Issues and PRs related to build files or the CI.
meta
Issues and PRs related to the general management of the project.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
labels
May 27, 2021
gengjiawen
approved these changes
May 27, 2021
targos
approved these changes
May 27, 2021
richardlau
reviewed
May 27, 2021
lpinca
approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with @richardlau's comment addressed.
Signed-off-by: pengjie <37610029@qq.com>
richardlau
approved these changes
May 28, 2021
gengjiawen
pushed a commit
that referenced
this pull request
May 29, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Landed in 4c508f5. Thanks for the contribution :) |
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: nodejs#38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update setup-node@v1 to setup-node@v2.
Signed-off-by: pengjie 37610029@qq.com