src: refactor to use locale functions #39014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code more readable. Signed-off-by: Darshan Sen <raisinten@gmail.com>
github-actions
bot
added
c++
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Jun 12, 2021
richardlau
approved these changes
Jun 12, 2021
This comment has been minimized.
This comment has been minimized.
RaisinTen
added
the
author ready
jasnell
approved these changes
Jun 14, 2021
|
Landed in 940f2c2 |
jasnell
pushed a commit
that referenced
this pull request
Jun 14, 2021
This makes the code more readable. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #39014 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 15, 2021
This makes the code more readable. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #39014 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
This makes the code more readable. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #39014 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
This makes the code more readable. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #39014 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
This makes the code more readable. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #39014 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
This makes the code more readable. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#39014 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code more readable.
Signed-off-by: Darshan Sen raisinten@gmail.com