Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove duplicate codes #39239

Merged
merged 1 commit into from
Jan 5, 2022
Merged

perf: remove duplicate codes #39239

merged 1 commit into from
Jan 5, 2022

Conversation

xiaoxiaojx
Copy link
Contributor

This line of code has been implemented in the prepareError function

// lib/_http_common.js

function prepareError(err, parser, rawPacket) {
  err.rawPacket = rawPacket || parser.getCurrentBuffer();
  if (typeof err.reason === 'string')
    err.message = `Parse Error: ${err.reason}`;
}

@github-actions github-actions bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 2, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 7, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Mesteery Mesteery removed the needs-ci PRs that need a full CI run. label Oct 12, 2021
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
@nodejs-github-bot

This comment has been minimized.

@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2021
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 27, 2021
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/39239
✔  Done loading data for nodejs/node/pull/39239
----------------------------------- PR info ------------------------------------
Title      perf: remove duplicate codes (#39239)
Author     Shaw <784487301@qq.com> (@xiaoxiaojx, first-time contributor)
Branch     xiaoxiaojx:patch-1 -> nodejs:master
Labels     http, author ready
Commits    1
 - remove duplicate codes
Committers 1
 - kaiduo 
PR-URL: https://github.com/nodejs/node/pull/39239
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Yongsheng Zhang 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39239
Reviewed-By: Robert Nagy 
Reviewed-By: James M Snell 
Reviewed-By: Yongsheng Zhang 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 02 Jul 2021 18:36:14 GMT
   ✔  Approvals: 3
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/39239#pullrequestreview-698577770
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39239#pullrequestreview-701561527
   ✔  - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/39239#pullrequestreview-829514403
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2021-12-24T15:38:29Z: https://ci.nodejs.org/job/node-test-pull-request/41648/
- Querying data for job/node-test-pull-request/41648/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
   9a85efaa7f..077c75beae  master     -> origin/master
✔  origin/master is now up-to-date
master is out of sync with origin/master. Mismatched commits:
 - ba1b7a2749 tls: permit null as a pfx value
 - 077c75beae tls: permit null as a pfx value
--------------------------------------------------------------------------------
HEAD is now at 077c75beae tls: permit null as a pfx value
   ✔  Reset to origin/master
- Downloading patch for 39239
From https://github.com/nodejs/node
 * branch                  refs/pull/39239/merge -> FETCH_HEAD
✔  Fetched commits as 077c75beaecc..00342b335efa
--------------------------------------------------------------------------------
[master 28ed5ff2f2] remove duplicate codes
 Author: Shaw <784487301@qq.com>
 Date: Sat Jul 3 02:33:35 2021 +0800
 1 file changed, 1 deletion(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
remove duplicate codes

This line of code has been implemented in the prepareError function

PR-URL: #39239
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

[master f511396186] remove duplicate codes
Author: Shaw 784487301@qq.com
Date: Sat Jul 3 02:33:35 2021 +0800
1 file changed, 1 deletion(-)
✖ f51139618623b3a56f2f5ea8c82518b1bf6e4886
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/1627255427

Trott pushed a commit to xiaoxiaojx/node that referenced this pull request Jan 5, 2022
This line of code has been implemented in the prepareError function.

PR-URL: nodejs#39239
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@Trott
Copy link
Member

Trott commented Jan 5, 2022

Landed in bad65ea.

Thanks for the contribution! 🎉

This line of code has been implemented in the prepareError function.

PR-URL: nodejs#39239
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@Trott Trott merged commit bad65ea into nodejs:master Jan 5, 2022
targos pushed a commit that referenced this pull request Jan 14, 2022
This line of code has been implemented in the prepareError function.

PR-URL: #39239
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
This line of code has been implemented in the prepareError function.

PR-URL: #39239
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
This line of code has been implemented in the prepareError function.

PR-URL: nodejs#39239
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
This line of code has been implemented in the prepareError function.

PR-URL: #39239
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants