Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove debugger workaround for AIX #39296

Merged
merged 1 commit into from
Jul 9, 2021
Merged

test: remove debugger workaround for AIX #39296

merged 1 commit into from
Jul 9, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 7, 2021

Optimistically removing workaround code in the debugger test tool.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2021
@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 7, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38889/

@tniessen
Copy link
Member

tniessen commented Jul 7, 2021

@Trott, could you summarize why this isn't necessary anymore?

Refs: #38431

@Trott
Copy link
Member Author

Trott commented Jul 7, 2021

@Trott, could you summarize why this isn't necessary anymore?

Refs: #38431

@tniessen I'd have to test to be sure, but my suspicion is that #38811 fixed it.

tniessen
tniessen approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimistically removing workaround code in the debugger test tool.

Optimistically approving!

@Trott
test: remove debugger workaround for AIX
ff975fe 
Optimistically removing workaround code in the debugger test tool.

PR-URL: nodejs#39296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@Trott
Copy link
Member Author

Trott commented Jul 9, 2021

Landed in ff975fe

@Trott Trott merged commit ff975fe into nodejs:master Jul 9, 2021
@Trott Trott deleted the workaround branch July 9, 2021 15:29
targos pushed a commit that referenced this pull request Jul 11, 2021
@Trott @targos
test: remove debugger workaround for AIX
11a8b81 
Optimistically removing workaround code in the debugger test tool.

PR-URL: #39296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
test: remove debugger workaround for AIX
5462023 
Optimistically removing workaround code in the debugger test tool.

PR-URL: #39296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @tniessen @jasnell @cjihrig @gireeshpunathil @targos