Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] src: use SPrintF in ProcessEmitWarning #39419

Closed
wants to merge 2 commits into from
Closed

[v14.x backport] src: use SPrintF in ProcessEmitWarning #39419

wants to merge 2 commits into from

Conversation

RaisinTen
Copy link
Contributor

PR-URL: #38758
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net

Original pull request: #38758

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Jul 17, 2021
RaisinTen added a commit to RaisinTen/node that referenced this pull request Jul 17, 2021
@RaisinTen
src: use SPrintF in ProcessEmitWarning
9ce9b14 
PR-URL: nodejs#38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: nodejs#39419
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen mentioned this pull request Jul 17, 2021
Closed
@aduh95
Copy link
Contributor

aduh95 commented Jul 17, 2021

You probably need to backport #39091 alongside it.

@RaisinTen
Copy link
Contributor Author

You probably need to backport #39091 alongside it.

@aduh95 Is there an example PR which backports multiple PRs?
Also, I tried to locally land it and it lands cleanly, so I'm not sure if I'm supposed to backport it myself.

@aduh95
Copy link
Contributor

aduh95 commented Jul 17, 2021 •
edited
Loading

You can use the following commands:

git reset 9ce9b14729788cfa2666117e3ab940cc4ad05307 --hard
git cherry-pick 19b80cc4ece088c0b02e556e217481b3ade744ff
git push origin HEAD:backport-38758-to-v14.x

Also, I tried to locally land it and it lands cleanly, so I'm not sure if I'm supposed to backport it myself.

I think it makes no sense to backport one without the other, so I'd say that yes, you are supposed to include both in this PR.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen
Copy link
Contributor Author

@aduh95 Thanks, done! PTAL.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 18, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 18, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39105/ 💚

RaisinTen and others added 2 commits July 19, 2021 16:12
@RaisinTen @richardlau
src: use SPrintF in ProcessEmitWarning
50afb5a 
PR-URL: nodejs#38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: nodejs#39419
@mmomtchev @richardlau
build: fix building with external builtins
86ab15d 
PR-URL: nodejs#39091
Fixes: nodejs#39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39143/

richardlau pushed a commit that referenced this pull request Jul 19, 2021
@RaisinTen @richardlau
src: use SPrintF in ProcessEmitWarning
b0ef28a 
PR-URL: #38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: #39419
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@mmomtchev @richardlau
build: fix building with external builtins
5f7c331 
PR-URL: #39091
Backport-PR-URL: #39419
Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau
Copy link
Member

Landed in 90fae0f...5f7c331

@richardlau richardlau closed this Jul 19, 2021
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@RaisinTen @richardlau
src: use SPrintF in ProcessEmitWarning
e7f266e 
PR-URL: #38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: #39419
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@mmomtchev @richardlau
build: fix building with external builtins
1ab4f81 
PR-URL: #39091
Backport-PR-URL: #39419
Fixes: #39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RaisinTen RaisinTen deleted the backport-38758-to-v14.x branch July 21, 2021 09:18
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@RaisinTen @foxxyz
src: use SPrintF in ProcessEmitWarning
221e75b 
PR-URL: nodejs#38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: nodejs#39419
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@mmomtchev @foxxyz
build: fix building with external builtins
72c0c71 
PR-URL: nodejs#39091
Backport-PR-URL: nodejs#39419
Fixes: nodejs#39090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RaisinTen @nodejs-github-bot @aduh95 @richardlau @targos @mmomtchev