Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add .mailmap entry for new email for existing contributor #39431

Closed
wants to merge 1 commit into from
Closed

meta: add .mailmap entry for new email for existing contributor #39431

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 18, 2021

No description provided.

@Trott Trott requested a review from RaisinTen July 18, 2021 23:46
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 18, 2021
@Trott
Copy link
Member Author

Trott commented Jul 18, 2021

@RaisinTen Not sure if you want to map the new email to the old one, like I did here, or if you'd rather do it the other way around and have the old email address map to the new one?

RaisinTen
RaisinTen approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 19, 2021
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 19, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@jasnell
Copy link
Member

jasnell commented Jul 19, 2021

Landed in d0b440c

@jasnell jasnell closed this Jul 19, 2021
jasnell pushed a commit that referenced this pull request Jul 19, 2021
@Trott @jasnell
meta: add .mailmap entry for new email for existing contributor
d0b440c 
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2021
@Trott @targos
meta: add .mailmap entry for new email for existing contributor
5ae5f88 
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
@Trott @BethGriggs
meta: add .mailmap entry for new email for existing contributor
d059ed9 
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
meta: add .mailmap entry for new email for existing contributor
69b56a3 
PR-URL: #39431
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
@Trott Trott deleted the update-ds branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @tniessen @RaisinTen @nodejs-github-bot