Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] lint rules for globals #39448

Closed
wants to merge 3 commits into from
Closed

[v14.x backport] lint rules for globals #39448

wants to merge 3 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 19, 2021 •
edited
Loading

This should unblock #39446, and should help notice uncompatible backports (lib/child_process.js was using AbortController as a global, but it's not available as a global on v14.x...).

Backports:

@aduh95
lib: add globalThis to primordials
bb94e59 
PR-URL: nodejs#38211
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
lib: enforce using primordials.globalThis instead of global
3eb7008 
PR-URL: nodejs#38230
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
lib: harden lint checks for globals
cacbccb 
PR-URL: nodejs#38419
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39128/

@github-actions github-actions bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Jul 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39130/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39136/

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 19, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
lib: add globalThis to primordials
c911273 
PR-URL: #38211
Backport-PR-URL: #39448
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
lib: enforce using primordials.globalThis instead of global
2ead4d2 
PR-URL: #38230
Backport-PR-URL: #39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
lib: harden lint checks for globals
0d2b4b7 
PR-URL: #38419
Backport-PR-URL: #39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@richardlau
Copy link
Member

Landed in 5f7c331...0d2b4b7.

@richardlau richardlau closed this Jul 20, 2021
This was referenced Jul 20, 2021
Merged
Merged
Closed
@aduh95 aduh95 deleted the v14.x-backport-lint-rules-for-globals branch July 20, 2021 12:01
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
lib: add globalThis to primordials
ea9003a 
PR-URL: #38211
Backport-PR-URL: #39448
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
lib: enforce using primordials.globalThis instead of global
d4f96bb 
PR-URL: #38230
Backport-PR-URL: #39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
lib: harden lint checks for globals
e3223ed 
PR-URL: #38419
Backport-PR-URL: #39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
lib: add globalThis to primordials
70773a6 
PR-URL: nodejs#38211
Backport-PR-URL: nodejs#39448
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
lib: enforce using primordials.globalThis instead of global
53803f2 
PR-URL: nodejs#38230
Backport-PR-URL: nodejs#39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
lib: harden lint checks for globals
3e7ed33 
PR-URL: nodejs#38419
Backport-PR-URL: nodejs#39448
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @richardlau @targos