Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix toWeb typo #39496

Closed
wants to merge 1 commit into from
Closed

stream: fix toWeb typo #39496

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 23, 2021

No description provided.

@ronag ronag requested review from mcollina and jasnell July 23, 2021 07:42
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 23, 2021
@ronag
Copy link
Member Author

ronag commented Jul 23, 2021

@nodejs/streams

@ronag
Copy link
Member Author

ronag commented Jul 23, 2021

Maybe the naming could be improved? It's really hard (impossible?) to tell difference between e.g.

newStreamReadableFromReadableStream
newReadableStreamFromStreamReadable

and also know which one does what. I had to literally go into the implementation check that it looks like it's working on a node stream and copy/paste the function name to make sure I got the right one.

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Jul 23, 2021
mcollina
mcollina approved these changes Jul 23, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jul 24, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39253/

ronag added a commit that referenced this pull request Jul 25, 2021
@ronag
stream: fix toWeb typo
79f4d5a 
PR-URL: #39496
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ronag
Copy link
Member Author

ronag commented Jul 25, 2021

Landed in 79f4d5a

@ronag ronag closed this Jul 25, 2021
@targos
Copy link
Member

targos commented Jul 26, 2021

Depends on #39134

@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @targos @mcollina @benjamingr @tniessen