Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: address flaky test-http-client-timeout-event #3968

Closed
wants to merge 1 commit into from
Closed

test: address flaky test-http-client-timeout-event #3968

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 22, 2015

Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: #2555

@Trott
test: address flaky test-http-client-timeout-event
a065aa6 
Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: nodejs#2555
@Trott Trott mentioned this pull request Nov 22, 2015
Closed
@Trott
Copy link
Member Author

Trott commented Nov 22, 2015

Stress test to show that this actually fixes the problem: https://ci.nodejs.org/job/node-stress-single-test/nodes=pi1-raspbian-wheezy/27/console

For good measure, stress test without this change to show that the problem still exists: https://ci.nodejs.org/job/node-stress-single-test/24/nodes=pi1-raspbian-wheezy/console

@mscdex mscdex added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Nov 22, 2015
@brendanashworth
Copy link
Contributor

This LGTM.

@r-52
Copy link
Contributor

r-52 commented Nov 22, 2015

LGTM

1 similar comment
@silverwind
Copy link
Contributor

LGTM

Trott added a commit that referenced this pull request Nov 23, 2015
@Trott @r-52
test: address flaky test-http-client-timeout-event
487de19 
Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: #2555
PR-URL: #3968

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@r-52
Copy link
Contributor

r-52 commented Nov 23, 2015

Thanks @Trott! - Landed in 487de19

@r-52 r-52 closed this Nov 23, 2015
@Fishrock123 Fishrock123 mentioned this pull request Nov 26, 2015
Closed
Trott added a commit that referenced this pull request Dec 1, 2015
@Trott
test: address flaky test-http-client-timeout-event
6b4cbd6 
Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: #2555
PR-URL: #3968

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this pull request Dec 4, 2015
@Trott @rvagg
test: address flaky test-http-client-timeout-event
edbe732 
Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: #2555
PR-URL: #3968

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this pull request Dec 5, 2015
@Trott @rvagg
test: address flaky test-http-client-timeout-event
665a35d 
Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: #2555
PR-URL: #3968

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
This was referenced Dec 8, 2015
Closed
Merged
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
Trott added a commit that referenced this pull request Dec 17, 2015
@Trott @jasnell
test: address flaky test-http-client-timeout-event
e66794f 
Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: #2555
PR-URL: #3968

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Trott added a commit that referenced this pull request Dec 23, 2015
@Trott @jasnell
test: address flaky test-http-client-timeout-event
0369ea9 
Use common.platformTimeout() to make test more reliable on Raspberry Pi.

Fixes: #2555
PR-URL: #3968

Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@Trott Trott deleted the platform-timeout branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @brendanashworth @r-52 @silverwind @mscdex @MylesBorins