-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: use validateObject
#39872
Closed
Closed
crypto: use validateObject
#39872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Aug 24, 2021
Mesteery
reviewed
Aug 24, 2021
The `validateObject()` validator can be used to cleanup validation and keep consistency.
Lxxyx
approved these changes
Aug 25, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 25, 2021
XadillaX
approved these changes
Aug 25, 2021
jasnell
approved these changes
Aug 25, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 31, 2021
VoltrexKeyva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 3, 2021
Ayase-252
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 17, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 17, 2021
Landed in 8a92018...55379eb |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
The `validateObject()` validator can be used to cleanup validation and keep consistency. PR-URL: #39872 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
The `validateObject()` validator can be used to cleanup validation and keep consistency. PR-URL: #39872 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
The `validateObject()` validator can be used to cleanup validation and keep consistency. PR-URL: #39872 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
validateObject()
validator can be used to cleanup validation andkeep consistency.