Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.x backport] module: support pattern trailers #39888

Closed

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Aug 25, 2021

Backport of #39635 and #40041 for Node.js 14.

This should wait for the release on 16 for two weeks before landing.

@github-actions github-actions bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. v14.x labels Aug 25, 2021
@targos targos added the blocked PRs that are blocked by other issues or PRs. label Sep 1, 2021
PR-URL: nodejs#39635
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
PR-URL: nodejs#40041
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@guybedford guybedford removed blocked PRs that are blocked by other issues or PRs. needs-ci PRs that need a full CI run. labels Oct 8, 2021
@guybedford
Copy link
Contributor Author

I've landed these backports on the staging branch for the next release.

@MylesBorins
Copy link
Contributor

Shouldn't this be Semver Minor as #39635 was semver minor?

@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 19, 2021
ljharb added a commit to inspect-js/has-package-exports that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants