-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.x backport] module: support pattern trailers #39888
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
esm
Issues and PRs related to the ECMAScript Modules implementation.
needs-ci
PRs that need a full CI run.
v14.x
labels
Aug 25, 2021
MylesBorins
force-pushed
the
v14.x-staging
branch
from
August 31, 2021 14:58
b3f51ee
to
327838d
Compare
targos
force-pushed
the
14-pattern-trailers
branch
from
September 4, 2021 06:52
bbb9771
to
83adba4
Compare
PR-URL: nodejs#39635 Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
guybedford
force-pushed
the
14-pattern-trailers
branch
from
September 15, 2021 08:55
83adba4
to
abd2ab9
Compare
PR-URL: nodejs#40041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
25 tasks
23 tasks
guybedford
removed
blocked
PRs that are blocked by other issues or PRs.
needs-ci
PRs that need a full CI run.
labels
Oct 8, 2021
I've landed these backports on the staging branch for the next release. |
This was referenced Oct 9, 2021
This was referenced Oct 18, 2021
Shouldn't this be Semver Minor as #39635 was semver minor? |
targos
added
the
semver-minor
PRs that contain new features and should be released in the next minor version.
label
Oct 19, 2021
ljharb
added a commit
to inspect-js/has-package-exports
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
esm
Issues and PRs related to the ECMAScript Modules implementation.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39635 and #40041 for Node.js 14.
This should wait for the release on 16 for two weeks before landing.