Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use assert.match instead of regexp.test #39928

Closed
wants to merge 1 commit into from
Closed

test: use assert.match instead of regexp.test #39928

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 29, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 29, 2021
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. and removed addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. labels Aug 29, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39694/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2021
Trott
Trott approved these changes Aug 29, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott Trott requested a review from BridgeAR August 29, 2021 14:14
antsmartian
antsmartian approved these changes Aug 29, 2021
View reviewed changes
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

targos added a commit that referenced this pull request Aug 31, 2021
@targos
test: use assert.match instead of regexp.test
508890d 
PR-URL: #39928
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos
Copy link
Member Author

targos commented Aug 31, 2021

Landed in 508890d

@targos targos closed this Aug 31, 2021
@targos targos deleted the assert-match branch August 31, 2021 16:50
targos added a commit that referenced this pull request Sep 6, 2021
@targos
test: use assert.match instead of regexp.test
b520dfa 
PR-URL: #39928
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos added a commit that referenced this pull request Sep 6, 2021
@targos
test: use assert.match instead of regexp.test
ca9b781 
PR-URL: #39928
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @jasnell @Trott @antsmartian @tniessen @BridgeAR @Lxxyx @RaisinTen