Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make version picker usable on mobile #39958

Closed
wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

@evanlucas evanlucas commented Aug 31, 2021

This makes the version picker usable on mobile devices.
Previously, the version picker was difficult to select from. This
change makes the #gtoc > ul > li elements have a display
of block instead of inline.

Before:

After:

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 31, 2021
@evanlucas evanlucas marked this pull request as ready for review August 31, 2021 15:47
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if instead we apply display: inline only if the user screen is bigger than 576px, instead of applying display: inline all the time and overwrite it with display: block when the screen is small. Non-blocking though.

@evanlucas
Copy link
Contributor Author

@aduh95 okay, pushed another commit with the suggested change. PTAL. Thanks!

Comment on lines 731 to 737
@media only screen and (max-width: 576px) {
#gtoc > ul > li {
display: block;
border-right: none;
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block doesn't seem to be necessary anymore.

Suggested change
@media only screen and (max-width: 576px) {
#gtoc > ul > li {
display: block;
border-right: none;
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, removed it. Thanks!

Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking since this seems useful, but just as heads up that we want to solve another semi-related problem that we have w/ our version picker and this may be getting revamped soon (see #36495).

/cc @ronag seeing as how this could be interesting to follow for documenting Undici version

@DerekNonGeneric
Copy link
Contributor

@evanlucas, seems like this is good to go as soon as the review point made by @aduh95 is addressed (or not).

I would like to see this land either way, but would need to rebase due to having multiple commits in the PR (please handle this).

@evanlucas
Copy link
Contributor Author

@DerekNonGeneric hey sorry, just now have time to get back to this. I'll get the suggested changes added and get this rebased today. Thanks!

This makes the version picker usable on mobile devices.
Previously, the version picker was difficult to select from. This
change makes the #gtoc > ul > li elements have a display
of `block` instead of `inline`.
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 22, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2021
@github-actions
Copy link
Contributor

Landed in 24cc239...c89d519

@github-actions github-actions bot closed this Sep 22, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 22, 2021
This makes the version picker usable on mobile devices.
Previously, the version picker was difficult to select from. This
change makes the #gtoc > ul > li elements have a display
of `block` instead of `inline`.

PR-URL: #39958
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
targos pushed a commit that referenced this pull request Oct 4, 2021
This makes the version picker usable on mobile devices.
Previously, the version picker was difficult to select from. This
change makes the #gtoc > ul > li elements have a display
of `block` instead of `inline`.

PR-URL: #39958
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants