Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing changes to generateKeyPair(Sync) #39963

Closed
wants to merge 1 commit into from
Closed

doc: add missing changes to generateKeyPair(Sync) #39963

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

As a prerequisite for #39927 without any semverness, add missing "changes:" entries to the generateKeyPair(Sync) APIs.

Refs: #26774
Refs: #26960

@tniessen tniessen requested a review from panva August 31, 2021 19:54
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Aug 31, 2021
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 31, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

panva pushed a commit that referenced this pull request Sep 1, 2021
@tniessen @panva
doc: add missing changes to generateKeyPair(Sync)
6155499 
Refs: #26774
Refs: #26960

PR-URL: #39963
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
Copy link
Member

panva commented Sep 1, 2021

Landed in 6155499

@panva panva closed this Sep 1, 2021
targos pushed a commit that referenced this pull request Sep 6, 2021
@tniessen @targos
doc: add missing changes to generateKeyPair(Sync)
80e686d 
Refs: #26774
Refs: #26960

PR-URL: #39963
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
@tniessen @targos
doc: add missing changes to generateKeyPair(Sync)
fc01dd9 
Refs: #26774
Refs: #26960

PR-URL: #39963
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Sep 6, 2021
Merged
@tniessen tniessen deleted the doc-missing-changes-generatekeypair branch October 7, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @panva @aduh95 @nodejs-github-bot