Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test coverage of fs.ReadStream with FileHandle #40018

Closed
wants to merge 1 commit into from
Closed

test: improve test coverage of fs.ReadStream with FileHandle #40018

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 6, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 6, 2021
@targos
Copy link
Member

targos commented Sep 18, 2021

@nodejs/fs

@targos targos added the fs Issues and PRs related to the fs subsystem / file system. label Sep 18, 2021
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 26, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40076/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40081/

This was referenced Sep 27, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 4, 2021
Open
Open
Open
@Lxxyx Lxxyx added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40174/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40176/

@github-actions github-actions bot mentioned this pull request Oct 7, 2021
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40190/

This was referenced Oct 8, 2021
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

Landed in eb65871...1d84e91

@github-actions github-actions bot closed this Oct 9, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 9, 2021
@aduh95 @nodejs-github-bot
test: improve test coverage of fs.ReadStream with FileHandle
1d84e91 
PR-URL: #40018
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@aduh95 aduh95 deleted the fs-filehandle-stream-coverage branch October 9, 2021 17:16
This was referenced Oct 10, 2021
Open
Open
Open
targos pushed a commit that referenced this pull request Oct 13, 2021
@aduh95 @targos
test: improve test coverage of fs.ReadStream with FileHandle
13d6a56 
PR-URL: #40018
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@richardlau richardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @targos @nodejs-github-bot @jasnell @Lxxyx