src: fix -Wunreachable-code-return error #40034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
targos
approved these changes
Sep 8, 2021
targos
reviewed
Sep 8, 2021
jasnell
approved these changes
Sep 8, 2021
lpinca
approved these changes
Sep 8, 2021
cjihrig
approved these changes
Sep 9, 2021
addaleax
approved these changes
Sep 9, 2021
|
Landed in f8836b2 |
codebytere
added a commit
that referenced
this pull request
Sep 11, 2021
PR-URL: #40034 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 14, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40034 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40034 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 23, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 27, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a
-Wunreachable-code-returncompilation error encountered in Electron surfaced during a recent Chromium roll.