Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: cleanup validation #40061

Closed
wants to merge 1 commit into from
Closed

Conversation

VoltrexKeyva
Copy link
Member

The validateString() validator should cleanup the validation and keep consistency.

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Sep 10, 2021
lib/internal/dns/utils.js Outdated Show resolved Hide resolved
@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 10, 2021
The `validateString()` validator should cleanup the validation and
keep consistency.
@aduh95 aduh95 removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 11, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 12, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 13, 2021

@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 13, 2021
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actions
Copy link
Contributor

Landed in de10ab2...eb44d19

@github-actions github-actions bot closed this Sep 16, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 16, 2021
The `validateString()` validator should cleanup the validation and
keep consistency.

PR-URL: #40061
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@VoltrexKeyva VoltrexKeyva deleted the patch-8 branch September 16, 2021 22:53
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
The `validateString()` validator should cleanup the validation and
keep consistency.

PR-URL: #40061
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
The `validateString()` validator should cleanup the validation and
keep consistency.

PR-URL: #40061
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dns Issues and PRs related to the dns subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants