Code

Refactor Timers#4007

Code

Closed

Fishrock123 wants to merge 29 commits intonodejs:masternodejs/node:masterfrom Fishrock123:refactor-timersFishrock123/node:refactor-timersCopy head branch name to clipboard

+213-228

Commits

Commits on Feb 25, 2016

• timers: refactor timers

  Show description for d171259
  Fishrock123

  committed
  d171259

  Copy full SHA for d171259

• timers: greatly improve code comments

  Show description for ba5fd2c
  Fishrock123

  committed
  ba5fd2c

  Copy full SHA for ba5fd2c

• timers: (fixup) refactor insert a bit more

  Show description for b9870e1
  Fishrock123

  committed
  b9870e1

  Copy full SHA for b9870e1

• timers: (fixup) remove some more unnecessary indentation

  Fishrock123

  committed
  acb53d0

  Copy full SHA for acb53d0

• timers: (fixup) fix my understanding of how timers work

  Fishrock123

  committed
  6493176

  Copy full SHA for 6493176

• timers: (fixup) handle domains properly again

  Fishrock123

  committed
  e8db191

  Copy full SHA for e8db191

• timers: (fixup) clean up code comments

  Fishrock123

  committed
  189c148

  Copy full SHA for 189c148

• timers: (fixup) correct domains dispose thing

  Fishrock123

  committed
  339ee8c

  Copy full SHA for 339ee8c

• timers: (fixup) address bnoordhuis nits

  Fishrock123

  committed
  234b580

  Copy full SHA for 234b580

• timers: (fixup) some more nits

  Fishrock123

  committed
  7e6bb6d

  Copy full SHA for 7e6bb6d

• timers: (fixup) fix message test

  Fishrock123

  committed
  65a2c8f

  Copy full SHA for 65a2c8f

• timers: (fixup) add a debuglog statement

  Fishrock123

  committed
  c3cb939

  Copy full SHA for c3cb939

• timers: (fixup) rvagg's list optimization

  Show description for 298d30f
  Fishrock123

  committed
  298d30f

  Copy full SHA for 298d30f

• timers: (fixup) Update code comments.

  Show description for 93e29e1
  Fishrock123

  committed
  93e29e1

  Copy full SHA for 93e29e1

• timers: (fixup) rename Timer to TimerWrap

  Show description for aa31fef
  Fishrock123

  committed
  aa31fef

  Copy full SHA for aa31fef

• timers: (fixup) spelling nits

  Fishrock123

  committed
  61dd4ab

  Copy full SHA for 61dd4ab

• timers: (fixup) remove "active" comment

  Show description for 06ab42e
  Fishrock123

  committed
  06ab42e

  Copy full SHA for 06ab42e

• timers: (fixup) fix comment

  Fishrock123

  committed
  aaf7e26

  Copy full SHA for aaf7e26

• timers: (fixup) move a code comment

  Fishrock123

  committed
  e28efc9

  Copy full SHA for e28efc9

• timers: (fixup) address most of Julien's comments

  Fishrock123

  committed
  739f9ea

  Copy full SHA for 739f9ea

• timers: (fixup) nit

  Fishrock123

  committed
  d86edc9

  Copy full SHA for d86edc9

• timers: (fixup) remove ascii drawing :(

  Show description for 5d9cc35
  Fishrock123

  committed
  5d9cc35

  Copy full SHA for 5d9cc35

• timers: (fixup) remove _ in tryOnTimeout

  Show description for 4120c5e
  Fishrock123

  committed
  4120c5e

  Copy full SHA for 4120c5e

• timers: (fixup) re-add awesome diagram

  Fishrock123

  committed
  11a96ad

  Copy full SHA for 11a96ad

• timers: (fixup) update comment preface

  Fishrock123

  committed
  13b2e0c

  Copy full SHA for 13b2e0c

• timers: (fixup) final? spelling nits

  Fishrock123

  committed
  1acab4d

  Copy full SHA for 1acab4d

• timers: (fixup) fix linting

  Fishrock123

  committed
  dc0961e

  Copy full SHA for dc0961e

Commits on Feb 26, 2016

• timers: (fixup) use a constructor function for lists

  Fishrock123

  committed
  a7d3be5

  Copy full SHA for a7d3be5

• timers: (fixup) update ascii graph for TimersList

  Fishrock123

  committed
  c87e455

  Copy full SHA for c87e455