-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: do not run test-corepack-yarn-install
with no internet
#40090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Sep 12, 2021
lpinca
approved these changes
Sep 12, 2021
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Sep 12, 2021
tniessen
approved these changes
Sep 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if CI runs internet tests.
targos
approved these changes
Sep 13, 2021
jasnell
approved these changes
Sep 13, 2021
mhdawson
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 16, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 16, 2021
Commit Queue failed- Loading data for nodejs/node/pull/40090 ✔ Done loading data for nodejs/node/pull/40090 ----------------------------------- PR info ------------------------------------ Title test: do not run `test-corepack-yarn-install` with no internet (#40090) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:yarn-test-internet -> nodejs:master Labels test, author ready Commits 1 - test: do not run `test-corepack-yarn-install` with no internet Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/40090 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40090 Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Michaël Zasso Reviewed-By: James M Snell Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Sep 2021 14:28:37 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40090#pullrequestreview-752188232 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752225082 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752385388 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752782487 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-754083383 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1243446870 |
github-actions
bot
added
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Sep 16, 2021
aduh95
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Sep 16, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 16, 2021
17 tasks
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 18, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 18, 2021
Landed in 2b080cb...3101c09 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 18, 2021
PR-URL: #40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Sep 19, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40090 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this test requires internet access to succeed, moving it to the relevant folder. I've also added a line to dump stdout when the test fails as it contains relevant info to understand the failure.