test: update OpenSSL3 error messages for 3.0.0+quic #40093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates two OpenSSL 3.0.0 error messages required for OpenSSL 3.0.0+quic.
nodejs-github-bot
added
needs-ci
targos
approved these changes
Sep 13, 2021
richardlau
approved these changes
Sep 13, 2021
github-actions
bot
removed
the
request-ci
|
Re. CI -- openssl300 is expected to fail as it is still on OpenSSL 3.0.0-alpha16. I will need to update the CI simultaneously with landing this PR. |
tniessen
approved these changes
Sep 13, 2021
richardlau
added
the
fast-track
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
|
CI is passing except for the expected failure on openssl300. I'll simultaneously update the CI and land this when this PR is ready to land (either fast tracked or after the wait period). |
jasnell
approved these changes
Sep 13, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 5c1adda...e016cc7 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2021
This commit updates two OpenSSL 3.0.0 error messages required for OpenSSL 3.0.0+quic. PR-URL: #40093 Refs: nodejs/build#2759 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 14, 2021
17 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
This commit updates two OpenSSL 3.0.0 error messages required for OpenSSL 3.0.0+quic. PR-URL: #40093 Refs: nodejs/build#2759 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
This commit updates two OpenSSL 3.0.0 error messages required for OpenSSL 3.0.0+quic. PR-URL: #40093 Refs: nodejs/build#2759 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates two OpenSSL 3.0.0 error messages required for
OpenSSL 3.0.0+quic.
Refs: nodejs/build#2759