Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove CRLF variable #40101

Closed
wants to merge 1 commit into from
Closed

http: remove CRLF variable #40101

wants to merge 1 commit into from

Conversation

shfshanyue
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Sep 14, 2021
@Trott
Copy link
Member

Trott commented Sep 14, 2021

Welcome, @shfshanyue, and thanks for the pull request.

I don't feel terribly strongly about this, but I'm not convinced CRLF is better than \r\n. To me at least, \r\n is explicit and clear. CRLF seems to be a variable-for-a-variable's sake and not significantly easier to understand. It's possible that I'm missing a nuance here, but I wonder if it wouldn't be better to go the other way and change all the usage of CRLF to \r\n. But I'll leave that up to the @nodejs/http folks. I'm happy to defer to others on something like this.

@mscdex
Copy link
Contributor

mscdex commented Sep 14, 2021

FWIW I'm not particularly fond of having a CRLF string variable either. It'd be better to just include the literal value where needed.

@shfshanyue
Copy link
Contributor Author

I think it would be better if change all the usage of CRLF to \r\n... I'll replace CRLF with \r\n and remove variable CRLF if necessary.

@mcollina
Copy link
Member

I prefer an explicit \r\n as well

@shfshanyue shfshanyue changed the title http: replace \r\n with CRLF http: remove CRLF variable Sep 14, 2021
@shfshanyue shfshanyue force-pushed the master branch 2 times, most recently from a624067 to e63733b Compare September 14, 2021 12:35
mcollina
mcollina approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mhdawson
mhdawson approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 14, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@lpinca
Copy link
Member

lpinca commented Sep 14, 2021

No objections, but please do not change it again after this lands. Refs: f4d3d12

@github-actions github-actions bot mentioned this pull request Sep 15, 2021
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39947/

@github-actions github-actions bot mentioned this pull request Sep 16, 2021
Open
18 tasks
@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Sep 16, 2021
mhdawson pushed a commit that referenced this pull request Sep 16, 2021
@shfshanyue @mhdawson
http: remove CRLF variable
e9fc678 
PR-URL: #40101
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member

Landed in e9fc678

@mhdawson mhdawson closed this Sep 16, 2021
This was referenced Sep 17, 2021
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Sep 20, 2021
Open
17 tasks
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@shfshanyue @BethGriggs
http: remove CRLF variable
cb8013f 
PR-URL: #40101
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@shfshanyue @BethGriggs
http: remove CRLF variable
bc9c2ca 
PR-URL: #40101
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This was referenced Sep 22, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@jasnell jasnell jasnell left review comments

@mhdawson mhdawson mhdawson approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@shfshanyue @Trott @mscdex @mcollina @nodejs-github-bot @lpinca @mhdawson @jasnell @Ayase-252 @VoltrexKeyva