Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix markdown indentation in lists #40142

Closed
wants to merge 1 commit into from
Closed

doc: fix markdown indentation in lists #40142

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 18, 2021 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 18, 2021
Trott
Trott approved these changes Sep 19, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I've got a change in the works to automate this for all our .md files but it's uncovered what I believe are some bugs in some dependencies in our tool chain that need to be fixed first. Happy to approve manual fixes in the meantime!)

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 19, 2021
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021
@github-actions
Copy link
Contributor

Landed in 4e7fe5a...931abc0

@github-actions github-actions bot closed this Sep 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 20, 2021
@targos @nodejs-github-bot
doc: fix markdown indentation in lists
931abc0 
PR-URL: #40142
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos deleted the fix-doc branch September 20, 2021 15:19
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
doc: fix markdown indentation in lists
e557e74 
PR-URL: #40142
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
doc: fix markdown indentation in lists
0254b4b 
PR-URL: #40142
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @jasnell @Trott @lpinca @cjihrig @tniessen @RaisinTen @nodejs-github-bot