-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix jittery scrolling #40215
fix jittery scrolling #40215
Conversation
This pr fixes the jittery scrolling behavior introduced in nodejs#37301 fix:nodejs#40099 refs:https://infrequently.org/2020/12/resize-resilient-deferred-rendering/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this. Can you please revert the unrelated stylistic changes? Also it'd be nice if the JavaScript code was using the same stylistic choices as the rest of the codebase – maybe you can put this to a separate .js
file in doc/api_assets
so the linter can autofix that for you.
@nodejs/website |
@aduh95 done! 👍 |
doc/template.html
Outdated
@@ -9,6 +9,7 @@ | |||
<link rel="stylesheet" href="assets/style.css"> | |||
<link rel="stylesheet" href="assets/hljs.css"> | |||
<link rel="canonical" href="https://nodejs.org/api/__FILENAME__.html"> | |||
<script src="assets/script.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add to the existing script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aduh95 asked to move it to a different file
maybe you can put this to a separate .js file in doc/api_assets so the linter can autofix that for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Sanchitverma78 I understand it's frustrating when a PR gets stalled because of a lack of reviews, please also understand that most (all?) Node.js contributors are doing reviews on their spare time, so you have to understand that sometimes things takes time because of a lack of volunteers and different priorities. |
@mscdex Are you able to confirm this is fixing the issue you were experiencing? |
he didnt reply |
I built with this just now and it doesn't fix the jittery scrolling for me, I'm sorry to say. Is there anything I can do to make this feedback more helpful? Like, would a screen recording help or something like that? |
I haven't tested this myself yet. Assuming this solution should fix this particular problem, I think there are a few things that probably need adjusting compared to the code used at the referenced article:
|
Additionally, it's possible that the current |
Superseded by #53510 |
Subsystem: doc
This pr fixes the jittery scrolling behavior introduced in
#37301
Fixes: #40099
Refs: https://infrequently.org/2020/12/resize-resilient-deferred-rendering/