Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in ESM example #40275

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in ESM example #40275

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Oct 1, 2021

existent is correct, existant is not. As far as I can tell, nonexistent is also more commonly used than non-existent.

Refs: #37468

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 1, 2021
@DerekNonGeneric DerekNonGeneric added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2021
@Lxxyx Lxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

Landed in 2a3a9b8...4bd8e0e

@github-actions github-actions bot closed this Oct 4, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 4, 2021
@tniessen @nodejs-github-bot
doc: fix typo in ESM example
4bd8e0e 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2021
@tniessen @danielleadams
doc: fix typo in ESM example
21b0792 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@tniessen @danielleadams
doc: fix typo in ESM example
77c926b 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@tniessen @danielleadams
doc: fix typo in ESM example
40777a3 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@tniessen @danielleadams
doc: fix typo in ESM example
5cd3677 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams
Copy link
Contributor

Added dont-land-on-v16.x label and waiting for #37468 before ready for v16.x.

@tniessen tniessen deleted the doc-fix-esm-typo-in-example branch October 7, 2021 16:42
@targos
Copy link
Member

targos commented Oct 9, 2021

@danielleadams if a PR should land but is waiting for other PRs to be ready -> backport-blocked.
The dont-land-on label is for PRs that should never land.

targos pushed a commit that referenced this pull request Oct 9, 2021
@tniessen @targos
doc: fix typo in ESM example
f0ecb6e 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 12, 2021
@tniessen @danielleadams
doc: fix typo in ESM example
3b3aaa0 
Refs: #37468

PR-URL: #40275
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@richardlau richardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

@juanarbol juanarbol juanarbol approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tniessen @danielleadams @targos @jasnell @benjamingr @lpinca @Lxxyx @juanarbol @DerekNonGeneric @nodejs-github-bot