tools: warn about duplicates when generating AUTHORS file #40304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Oct 4, 2021
Comment on lines
13
to
15
| get(key) { return this._map.get(key.toLowerCase()); } | ||
| has(key) { return this._map.has(key.toLowerCase()); } | ||
| set(key, value) { return this._map.set(key.toLowerCase(), value); } |
There was a problem hiding this comment.
Shouldn't we be using localeCompare if we are passing names in addition to email addresses?
There was a problem hiding this comment.
Asking my question another way: How/where would it be used? We're not comparing anything, at least not explicitly. Can you either show some code (or pseudocode) and/or some name/email addresses that would be a problem if we don't use localeCompare? I'm not clear on what the benefit is in this context or even how it would be used.
jasnell
approved these changes
Oct 7, 2021
Trott
added
the
author ready
Lxxyx
approved these changes
Oct 9, 2021
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 9, 2021
PR-URL: nodejs#40304 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
|
Landed in d6d6b05 |
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #40304 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.