Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty: support more CI services in getColorDepth #40385

Closed
wants to merge 4 commits into from
Closed

tty: support more CI services in getColorDepth #40385

wants to merge 4 commits into from

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Oct 9, 2021

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem. labels Oct 9, 2021
mscdex
mscdex reviewed Oct 9, 2021
View reviewed changes
lib/internal/tty.js Outdated Show resolved Hide resolved
mscdex
mscdex reviewed Oct 9, 2021
View reviewed changes
lib/internal/tty.js Outdated Show resolved Hide resolved
mscdex
mscdex reviewed Oct 9, 2021
View reviewed changes
lib/internal/tty.js Outdated Show resolved Hide resolved
@Richienb @mscdex
Update lib/internal/tty.js
53b3b5c 
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
@Richienb Richienb requested a review from mscdex October 10, 2021 00:04
@Ayase-252 Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 20, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 20, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40383/

targos pushed a commit that referenced this pull request Oct 23, 2021
@Richienb @targos
tty: support more CI services in getColorDepth
f194082 
PR-URL: #40385
Refs: sindresorhus/yoctocolors#5
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos
Copy link
Member

targos commented Oct 23, 2021

Landed in f194082

@targos targos closed this Oct 23, 2021
targos pushed a commit that referenced this pull request Oct 23, 2021
@Richienb @targos
tty: support more CI services in getColorDepth
a95e344 
PR-URL: #40385
Refs: sindresorhus/yoctocolors#5
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
@Richienb @BethGriggs
tty: support more CI services in getColorDepth
7d550ad 
PR-URL: #40385
Refs: sindresorhus/yoctocolors#5
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@trentm trentm mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@JungMinu JungMinu JungMinu approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@mscdex mscdex Awaiting requested review from mscdex

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Richienb @nodejs-github-bot @targos @mscdex @jasnell @JungMinu @BridgeAR @Ayase-252