-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src,crypto: use std::variant
in DH params
#40457
Closed
RaisinTen
wants to merge
1
commit into
nodejs:master
from
RaisinTen:src,crypto/use-std-variant-in-DH-params
Closed
src,crypto: use std::variant
in DH params
#40457
RaisinTen
wants to merge
1
commit into
nodejs:master
from
RaisinTen:src,crypto/use-std-variant-in-DH-params
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Oct 14, 2021
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src,crypto/use-std-variant-in-DH-params
branch
from
October 14, 2021 14:11
869f42a
to
29a2559
Compare
This comment has been minimized.
This comment has been minimized.
addaleax
approved these changes
Oct 14, 2021
Added dont-land- labels as |
RaisinTen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 14, 2021
richardlau
approved these changes
Oct 14, 2021
tniessen
approved these changes
Oct 14, 2021
23 tasks
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 16, 2021
This was referenced Oct 18, 2021
RaisinTen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 22, 2021
github-actions
bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 22, 2021
Landed in 68dc180...5c7af3f |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 22, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40457 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
31 tasks
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40457 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen darshan.sen@postman.com