Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add auth option case for url.format #40516

Merged
merged 2 commits into from
Dec 2, 2021
Merged

test: Add auth option case for url.format #40516

merged 2 commits into from
Dec 2, 2021

Conversation

wafuwafu13
Copy link
Contributor

@wafuwafu13 wafuwafu13 commented Oct 19, 2021 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 19, 2021
@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Oct 26, 2021
Open
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 29, 2021
Open
33 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Oct 30, 2021
Open
Open
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 3, 2021
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Nov 23, 2021
Open
45 tasks
@aduh95 aduh95 added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 24, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41091/

This was referenced Nov 26, 2021
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41265/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41274/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41275/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41276/

@Ayase-252 Ayase-252 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2021
Ayase-252
Ayase-252 approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@Ayase-252 Ayase-252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, we made CI green. Thanks for contribution!

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2021
@nodejs-github-bot nodejs-github-bot merged commit 9e0fb1a into nodejs:master Dec 2, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 9e0fb1a

This was referenced Dec 3, 2021
Open
Open
Open
Open
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@danielleadams
test: add auth option case for url.format
3da0704 
PR-URL: #40516
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@danielleadams
test: add auth option case for url.format
de1748a 
PR-URL: #40516
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@danielleadams
test: add auth option case for url.format
d8ce6f6 
PR-URL: #40516
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@danielleadams
test: add auth option case for url.format
bbe3bc6 
PR-URL: #40516
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Linkgoron
test: add auth option case for url.format
77b7521 
PR-URL: nodejs#40516
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@danielleadams
test: add auth option case for url.format
b9567d9 
PR-URL: #40516
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wafuwafu13 @nodejs-github-bot @Ayase-252 @jasnell @VoltrexKeyva @aduh95