Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: add a condition to if in case of a bug. #40549

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

module: add a condition to if in case of a bug. #40549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e7d26e
module: refactor get_format
iam-frankqiu Oct 21, 2021
c52be61
module: fix bug
iam-frankqiu Oct 21, 2021
1d612d4
esm: add a condition to if
iam-frankqiu Oct 27, 2021
d781db9
module: add some tests
iam-frankqiu Nov 2, 2021
e54325a
module: fix lint err
iam-frankqiu Nov 3, 2021
8d330e2
module: fix lint err
iam-frankqiu Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/internal/modules/esm/get_format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,18 @@ const protocolHandlers = ObjectAssign(ObjectCreate(null), {
},
'file:'(parsed, url) {
const ext = extname(parsed.pathname);
let format;
let format = null;

if (ext === '.js') {
format = getPackageType(parsed.href) === 'module' ? 'module' : 'commonjs';
iam-frankqiu marked this conversation as resolved.
Show resolved Hide resolved
} else {
format = extensionFormatMap[ext];
}
if (!format) {
if (experimentalSpecifierResolution === 'node') {
if (
experimentalSpecifierResolution === 'node' &&
legacyExtensionFormatMap[ext]
) {
process.emitWarning(
'The Node.js specifier resolution in ESM is experimental.',
'ExperimentalWarning');
Expand All @@ -73,7 +76,7 @@ const protocolHandlers = ObjectAssign(ObjectCreate(null), {
}
}

return format || null;
return format;
},
'node:'() { return 'builtin'; },
});
Expand Down
14 changes: 14 additions & 0 deletions test/es-module/test-esm-get-format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
'use strict';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a flag for the test to work.

Suggested change
'use strict';
// Flags: --expose-internals
'use strict';

require('../common');
const assert = require('assert');
const { defaultGetFormat } = require('internal/modules/esm/get_format');

{
const url = new URL('file://example.com/foo/bar.js');
assert.strictEqual(defaultGetFormat(url), 'commonjs');
}

{
const url = new URL('file://example.com/foo/bar.whatever');
assert.throws(() => defaultGetFormat(url), { name: 'TypeError', message: /Unknown file extension whatever/ });
}