Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add VoltrexMaster to collaborators #40566

Closed
wants to merge 1 commit into from
Closed

doc: add VoltrexMaster to collaborators #40566

wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

Fixes: #40323

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 22, 2021
@VoltrexKeyva VoltrexKeyva added fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs. doc Issues and PRs related to the documentations. and removed doc Issues and PRs related to the documentations. labels Oct 22, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @VoltrexMaster. Please 👍 to approve.

VoltrexKeyva added a commit that referenced this pull request Oct 22, 2021
@VoltrexKeyva
doc: add VoltrexMaster to collaborators
dd7a929 
Fixes: #40323

PR-URL: #40566
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@VoltrexKeyva
Copy link
Member Author

Landed in dd7a929

@VoltrexKeyva VoltrexKeyva deleted the add-new-collaborator branch October 22, 2021 16:57
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2021
targos pushed a commit that referenced this pull request Oct 23, 2021
@VoltrexKeyva @targos
doc: add VoltrexMaster to collaborators
89b34ec 
Fixes: #40323

PR-URL: #40566
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Nov 8, 2021
@targos
2021-11-09, Version 17.1.0 (Current)
2776ddb 
Notable changes:

doc:
  * add VoltrexMaster to collaborators (voltrexmaster) #40566
esm:
  * (SEMVER-MINOR) add support for JSON import assertion (Antoine du Hamel) #40250
lib:
  * (SEMVER-MINOR) add unsubscribe method to non-active DC channels (simon-id) #40433
  * (SEMVER-MINOR) add return value for DC channel.unsubscribe (simon-id) #40433
v8:
  * (SEMVER-MINOR) multi-tenant promise hook api (Stephen Belanger) #39283

PR-URL: TODO
targos added a commit that referenced this pull request Nov 8, 2021
@targos
2021-11-09, Version 17.1.0 (Current)
2b1744b 
Notable changes:

doc:
  * add VoltrexMaster to collaborators (voltrexmaster) #40566
esm:
  * (SEMVER-MINOR) add support for JSON import assertion (Antoine du Hamel) #40250
lib:
  * (SEMVER-MINOR) add unsubscribe method to non-active DC channels (simon-id) #40433
  * (SEMVER-MINOR) add return value for DC channel.unsubscribe (simon-id) #40433
v8:
  * (SEMVER-MINOR) multi-tenant promise hook api (Stephen Belanger) #39283

PR-URL: #40758
@targos targos mentioned this pull request Nov 8, 2021
Merged
targos added a commit that referenced this pull request Nov 9, 2021
@targos
2021-11-09, Version 17.1.0 (Current)
b022d19 
Notable changes:

doc:
  * add VoltrexMaster to collaborators (voltrexmaster) #40566
esm:
  * (SEMVER-MINOR) add support for JSON import assertion (Antoine du Hamel) #40250
lib:
  * (SEMVER-MINOR) add unsubscribe method to non-active DC channels (simon-id) #40433
  * (SEMVER-MINOR) add return value for DC channel.unsubscribe (simon-id) #40433
v8:
  * (SEMVER-MINOR) multi-tenant promise hook api (Stephen Belanger) #39283

PR-URL: #40758
BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
@VoltrexKeyva @BethGriggs
doc: add VoltrexMaster to collaborators
755c085 
Fixes: #40323

PR-URL: #40566
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Nov 26, 2021
@BethGriggs
2021-11-30, Version 16.13.1 'Gallium' (LTS)
8e7ddda 
Notable changes:

doc:
  * add VoltrexMaster to collaborators (voltrexmaster) #40566

PR-URL: TODO
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
BethGriggs added a commit that referenced this pull request Nov 26, 2021
@BethGriggs
2021-11-30, Version 16.13.1 'Gallium' (LTS)
f369577 
Notable changes:

doc:
  * add VoltrexMaster to collaborators (voltrexmaster) #40566

PR-URL: #40974
BethGriggs added a commit that referenced this pull request Nov 29, 2021
@BethGriggs
2021-11-30, Version 16.13.1 'Gallium' (LTS)
5bd3d16 
Notable changes:

doc:
  * add VoltrexMaster to collaborators (voltrexmaster) #40566

PR-URL: #40974
BethGriggs added a commit that referenced this pull request Nov 30, 2021
@BethGriggs
2021-11-30, Version 16.13.1 'Gallium' (LTS)
88cfa36 
Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974
BethGriggs added a commit that referenced this pull request Dec 1, 2021
@BethGriggs
2021-12-01, Version 16.13.1 'Gallium' (LTS)
12029ce 
Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974
BethGriggs added a commit that referenced this pull request Dec 1, 2021
@BethGriggs
2021-12-01, Version 16.13.1 'Gallium' (LTS)
6f74010 
Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@BethGriggs @Linkgoron
2021-12-01, Version 16.13.1 'Gallium' (LTS)
5fd35c5 
Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [nodejs#40643](nodejs#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [nodejs#40660](nodejs#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [nodejs#40566](nodejs#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [nodejs#40325](nodejs#40325)

PR-URL: nodejs#40974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nominating VoltrexMaster as a collaborator
6 participants
@VoltrexKeyva @Trott @cjihrig @aduh95 @nodejs-github-bot @Mesteery