Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: consolidate AUTHORS entries for darai0512 #40569

Closed
wants to merge 1 commit into from
Closed

meta: consolidate AUTHORS entries for darai0512 #40569

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 22, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 22, 2021
@Trott
Copy link
Member Author

Trott commented Oct 22, 2021

@darai0512 This removes your darai@ email address and leaves your darai0512@ email address. If you'd prefer we switch that, please comment. Thanks!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 22, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2021
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 24, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2021
@github-actions
Copy link
Contributor

Landed in 31d7d6c...ce0e21e

@github-actions github-actions bot closed this Oct 24, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 24, 2021
@Trott @nodejs-github-bot
meta: consolidate AUTHORS entries for darai0512
ce0e21e 
PR-URL: #40569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
@Trott @targos
meta: consolidate AUTHORS entries for darai0512
08e7a2f 
PR-URL: #40569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@Trott @BethGriggs
meta: consolidate AUTHORS entries for darai0512
0003cb6 
PR-URL: #40569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@Trott Trott deleted the authors-da branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @lpinca @Lxxyx @nodejs-github-bot @Mesteery