http: change totalSocketCount only on socket creation or when the socket is closed #40572

jodevsa · 2021-10-22T23:29:18Z

Trott

Can you please add a test?

jodevsa · 2021-10-23T00:22:50Z

@Trott
I added tests, but turns out it's not a bug :D I'll add more details in the issue, and see how to move forward. I think we have another bug, like the socketCount going down to -1 🙈

test/parallel/test-http-agent-keepalive.js

mcollina

lgtm

jodevsa · 2021-10-23T10:49:58Z

@mcollina is there a way to rerun the failed test?

nodejs-github-bot · 2021-10-23T12:11:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40414/

lib/_http_agent.js

test/parallel/test-http-upgrade-client.js

test/parallel/test-http-upgrade-agent.js

Trott · 2021-11-08T22:05:55Z

Current failures are #40738

Now that that has closed, I imagine a rebase against master and a force push to the PR branch would fix things.

jodevsa · 2021-11-08T22:57:13Z

@Trott I will try it out. Thanks for the update :)

jodevsa · 2021-11-09T09:16:41Z

@Trott 1 failed :(

mcollina

lgtm

mcollina · 2021-11-09T10:11:39Z

@nodejs/build do you know why asan fails? Can we land anyway?

I'm trying to land this using "node-core-utils" and it is stuck at

Querying API for job/node-test-pull-request/40795/

Trott · 2021-11-09T13:09:27Z

@nodejs/build do you know why asan fails?

I don't know why ASAN fails frequently, but there's a Re-run Workflow button that I always click. I've re-run it here.

Can we land anyway?

Please don't. If it's a real failure, we want to know.

nodejs-github-bot · 2021-11-09T23:30:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40807/

PR-URL: nodejs#40572 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

Trott · 2021-11-10T02:16:36Z

Landed in d8f1823

Trott · 2021-11-10T02:16:57Z

Thanks for the contribution! 🎉

And thanks for your patience and persistence!

PR-URL: #40572 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Oct 22, 2021

Trott reviewed Oct 22, 2021

View reviewed changes

jodevsa force-pushed the remove_socket_count_increment branch from a74c6c9 to d50c671 Compare October 23, 2021 00:20

jodevsa changed the title ~~http: do not increment socketCount on existing socket reuse~~ http: add tests for http agent totalSocketCount Oct 23, 2021

jodevsa mentioned this pull request Oct 23, 2021

Can someone take a look at this code in _http_agent.js there may be a bug. #40452

Closed

jodevsa commented Oct 23, 2021

View reviewed changes

test/parallel/test-http-agent-keepalive.js Outdated Show resolved Hide resolved

jodevsa commented Oct 23, 2021

View reviewed changes

test/parallel/test-http-agent-keepalive.js Outdated Show resolved Hide resolved

jodevsa force-pushed the remove_socket_count_increment branch from d50c671 to c907459 Compare October 23, 2021 08:07

jodevsa changed the title ~~http: add tests for http agent totalSocketCount~~ http: change totalSocketCount only on socket creation or when the socket is closed Oct 23, 2021

jodevsa force-pushed the remove_socket_count_increment branch 2 times, most recently from 56415f8 to 2116b6a Compare October 23, 2021 08:18

mcollina approved these changes Oct 23, 2021

View reviewed changes

VoltrexKeyva approved these changes Oct 23, 2021

View reviewed changes

lpinca reviewed Oct 23, 2021

View reviewed changes

lib/_http_agent.js Show resolved Hide resolved

This comment has been minimized.

Sign in to view

jodevsa force-pushed the remove_socket_count_increment branch 2 times, most recently from aa0cced to 63d8bf7 Compare October 23, 2021 20:00

jodevsa requested a review from lpinca October 23, 2021 20:00

jodevsa force-pushed the remove_socket_count_increment branch from 72c7b65 to 09ab76b Compare October 23, 2021 20:18

github-actions bot mentioned this pull request Oct 24, 2021

CI Reliability 2021-10-24 nodejs/reliability#96

Open

31 tasks

lpinca reviewed Oct 24, 2021

View reviewed changes

test/parallel/test-http-upgrade-client.js Outdated Show resolved Hide resolved

jodevsa force-pushed the remove_socket_count_increment branch 2 times, most recently from 9b9bf8c to e3f9bdc Compare October 24, 2021 11:34

jodevsa requested a review from lpinca October 24, 2021 11:36

lpinca approved these changes Oct 24, 2021

View reviewed changes

test/parallel/test-http-upgrade-agent.js Show resolved Hide resolved

jasnell approved these changes Oct 24, 2021

View reviewed changes

github-actions bot mentioned this pull request Nov 9, 2021

CI Reliability 2021-11-09 nodejs/reliability#112

Open

23 tasks

This comment has been minimized.

Sign in to view

mcollina approved these changes Nov 9, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Nov 10, 2021

CI Reliability 2021-11-10 nodejs/reliability#113

Open

26 tasks

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2021

Trott force-pushed the remove_socket_count_increment branch from ef2c276 to d8f1823 Compare November 10, 2021 02:16

Trott merged commit d8f1823 into nodejs:master Nov 10, 2021

targos mentioned this pull request Nov 26, 2021

v17.2.0 release proposal #40983

Merged

danielleadams mentioned this pull request Feb 1, 2022

v16.14.0 proposal #41804

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: change totalSocketCount only on socket creation or when the socket is closed #40572

http: change totalSocketCount only on socket creation or when the socket is closed #40572

jodevsa commented Oct 22, 2021 •

edited

Loading

Trott left a comment

jodevsa commented Oct 23, 2021

mcollina left a comment

jodevsa commented Oct 23, 2021

nodejs-github-bot commented Oct 23, 2021

This comment has been minimized.

Trott commented Nov 8, 2021

jodevsa commented Nov 8, 2021

jodevsa commented Nov 9, 2021

This comment has been minimized.

mcollina left a comment

mcollina commented Nov 9, 2021

Trott commented Nov 9, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Nov 9, 2021

Trott commented Nov 10, 2021

Trott commented Nov 10, 2021

http: change totalSocketCount only on socket creation or when the socket is closed #40572

http: change totalSocketCount only on socket creation or when the socket is closed #40572

Conversation

jodevsa commented Oct 22, 2021 • edited Loading

Trott left a comment

Choose a reason for hiding this comment

jodevsa commented Oct 23, 2021

mcollina left a comment

Choose a reason for hiding this comment

jodevsa commented Oct 23, 2021

nodejs-github-bot commented Oct 23, 2021

This comment has been minimized.

Trott commented Nov 8, 2021

jodevsa commented Nov 8, 2021

jodevsa commented Nov 9, 2021

This comment has been minimized.

mcollina left a comment

Choose a reason for hiding this comment

mcollina commented Nov 9, 2021

Trott commented Nov 9, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Nov 9, 2021

Trott commented Nov 10, 2021

Trott commented Nov 10, 2021

jodevsa commented Oct 22, 2021 •

edited

Loading