Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: tweak guidance for modules in core #40601

Closed
wants to merge 1 commit into from
Closed

doc: tweak guidance for modules in core #40601

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Generalize guidance so that it is not specific
to modules.

Signed-off-by: Michael Dawson mdawson@devrus.com

@mhdawson mhdawson requested a review from Trott October 25, 2021 21:19
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 25, 2021
@mhdawson
Copy link
Member Author

Unfortunately the diff is not great due to the file rename. It's mostly

  • change module -> component
  • updates to initial paragraphs to cover that a component can be included as module, dependency, etc.

@mhdawson
Copy link
Member Author

@Trott addressed your comments if you can take another look.

@mhdawson
Copy link
Member Author

mhdawson commented Nov 2, 2021

@Trott updated.

@ronag would be great if you took a look as well

@mhdawson
Copy link
Member Author

mhdawson commented Nov 9, 2021

@Trott one more look?

Trott
Trott reviewed Nov 9, 2021
View reviewed changes
doc/guides/components-in-core.md Outdated Show resolved Hide resolved
doc/guides/components-in-core.md Outdated Show resolved Hide resolved
@Trott Trott mentioned this pull request Nov 12, 2021
Closed
@mhdawson
Copy link
Member Author

@Trott updated again.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2021
@Trott
Copy link
Member

Trott commented Nov 13, 2021

Probably worth a ping to @nodejs/tsc on this.

mcollina
mcollina approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson @Trott
doc: tweak guidance for modules in core
b323c63 
Generalize guidance so that it is not specific
to modules.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#40601
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 15, 2021

Landed in b323c63

@Trott Trott closed this Nov 15, 2021
targos pushed a commit that referenced this pull request Nov 21, 2021
@mhdawson @targos
doc: tweak guidance for modules in core
c91a9ab 
Generalize guidance so that it is not specific
to modules.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40601
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@mhdawson @danielleadams
doc: tweak guidance for modules in core
b989652 
Generalize guidance so that it is not specific
to modules.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40601
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@mhdawson @danielleadams
doc: tweak guidance for modules in core
e70c361 
Generalize guidance so that it is not specific
to modules.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #40601
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@ronag ronag ronag approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mhdawson @Trott @mcollina @jasnell @ronag @tniessen @nodejs-github-bot