process: refactor process per thread #40746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
VoltrexKeyva
force-pushed
the
refactor-process-per-thread
branch
from
36baf89
to
1ede072
Compare
aduh95
reviewed
Nov 7, 2021
VoltrexKeyva
force-pushed
the
refactor-process-per-thread
branch
2 times, most recently
from
849b46f
to
31df23c
Compare
• Validate the `prevValue` parameter in the `cpuUsage()` function at the correct place. • Use validation methods for consistency. • Use the logical OR assignment operator (`||=`) where appropriate. • Use `StringPrototypeReplaceAll()` where appropriate.
VoltrexKeyva
force-pushed
the
refactor-process-per-thread
branch
from
31df23c
to
1d9a80c
Compare
aduh95
approved these changes
Nov 10, 2021
jasnell
approved these changes
Nov 13, 2021
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This was referenced Nov 14, 2021
|
According to the console output of the Jenkins CI checks, none of the actual tests seem to be failing, but the Jenkins CI checks seem to fail either way due to a Java error raised by disconnecting from the specified backing channel. Anything we can do about that? |
|
Given every platform and also the GitHub Action tests workflows are failing and we're not seeing the same across-the-board failures on other PR's there's likely to be some non-obvious issue with this PR. |
This was referenced Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Validate the
prevValueparameter in thecpuUsage()function at the correct place.• Use validation methods for consistency.
• Use the logical OR assignment operator (
||=) where appropriate.• Use
StringPrototypeReplaceAll()where appropriate.