stream: unify writableErrored and readableErrored #40799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these should always refer to the same error, hence there is no reason to separate them.
|
@nodejs/streams |
mscdex
added
the
semver-major
addaleax
reviewed
Nov 13, 2021
| @@ -621,7 +621,7 @@ added: | |||
| Number of times [`writable.uncork()`][stream-uncork] needs to be | |||
| called in order to fully uncork the stream. | |||
|
|
|||
| ##### `writable.writableErrored` | |||
| ##### `writable.errored` | |||
There was a problem hiding this comment.
These props have never made it to any release... is that really necessary?
jasnell
reviewed
Nov 13, 2021
| @@ -1239,7 +1239,7 @@ ObjectDefineProperties(Readable.prototype, { | |||
| } | |||
| }, | |||
|
|
|||
| readableErrored: { | |||
| errored: { | |||
There was a problem hiding this comment.
Do the readableErrored and writableErrored need to go through a deprecation cycle first? Those should likely be runtime deprecated aliases, yes?
There was a problem hiding this comment.
Not really. They haven’t been in any release.
lpinca
approved these changes
Nov 13, 2021
lpinca
removed
the
semver-major
|
I've remove the semver-major label as per #40799 (comment). |
ronag
added
the
author ready
jasnell
approved these changes
Nov 14, 2021
This was referenced Nov 16, 2021
|
Landed in 340b770 |
This was referenced Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these should always refer to the same error, hence there is no reason to separate them.
Refs: #40696