Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: return undefined writable/readable #40803

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stream: return undefined writable/readable #40803

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 13, 2021

Return undefined for writable/readable props if the stream
never was writable/readable. This way we can differentiate between
Duplex streams that never was writable/readable and Duplex streams
which has finished writing/reading.

@ronag
stream: return undefined writable/readable
0ecf392 
Return undefined for writable/readable props if the stream
never was writable/readable. This way we can differentiate between
Duplex streams that never was writable/readable and Duplex streams
which has finished writing/reading.
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Nov 13, 2021
@ronag ronag requested a review from mcollina November 13, 2021 13:47
@ronag
Copy link
Member Author

ronag commented Nov 13, 2021

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 13, 2021
@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 13, 2021
@addaleax
Copy link
Member

I think this needs docs changes (prose + changes: entry)?

@mscdex mscdex added the needs-citgm PRs that need a CITGM CI run. label Nov 13, 2021
mcollina
mcollina approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after a CITGM pass.

@ronag
Copy link
Member Author

ronag commented Nov 18, 2021

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2792/

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run. labels Nov 18, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40966/

This was referenced Nov 19, 2021
Open
Open
Open
Open
Open
Open
@aduh95
Copy link
Contributor

aduh95 commented Apr 3, 2022

It looks like there are related CI failures.

@aduh95
Copy link
Contributor

aduh95 commented Sep 8, 2022

There are a few CI failures that would need to be addressed in order to land this.

mcollina
mcollina approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Sep 8, 2022

I think this would need to be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ronag @addaleax @nodejs-github-bot @aduh95 @mcollina @jasnell @JungMinu @mscdex