v14.18.2 proposal #40969
Merged
v14.18.2 proposal #40969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #37294 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #40127 Reviewed-By: Richard Lau <rlau@redhat.com>
The build-docs workflow runs tests which means it is sensitive to globals and can fail if the `node` running the test has a different set of globals to that expected by `test/common`. PR-URL: #40939 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38482 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot
added
build
|
This is a patch release. #40564 is on my radar to include in this release if I can get the CI to pass. Please let me know if there are any other semver patch things that should be considered. Please don't derail this PR with discussions around semver-minors as they're out of scope for this release. We've penciled in a Node.js 14 semver-minor for sometime in January (nodejs/Release#567) to pick up the commits already on |
tniessen
approved these changes
Nov 25, 2021
It can happen that the `NearHeapLimit` callback is called while calling the `oninit()` function on `MessagePort` construction causing a deadlock when the `Worker::Exit()` method is called, as the `mutex_` was already held on the `CreateEnvMessagePort()` method. To fix it, just use the `mutex_` to protect the `child_port_data_` variable and avoid holding it when creating the `MessagePort`. Also, return early from `Worker::Run()` if the worker message port could not be created. Fixes: #38208 PR-URL: #38403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #40325 Backport-PR-URL: #40564 Fixes: #40305 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Notable changes This release contains a c-ares update to fix a regression introduced in Node.js 14.17.5 resolving CNAME records containing underscores (#39780). Also included are commits to allow Node.js 14 to continue to build and pass tests on our Jenkins CI, including adding Python 3.10 to the list of allowable Python versions for building. PR-URL: #40969
richardlau
force-pushed
the
v14.18.2-proposal
branch
from
a9ff5e3 to
c3dd76a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/41143/ (✔️) CITGM -- I ran a second set of 14.18.1/14.18.2 runs as Jenkins was showing a 26 extra failures in 14.18.2 (30 in the second set) but this turns out to be because 14.18.1 doesn't build on our Windows CI hosts because it doesn't have the Python 3.10 compatibility patches. 14.18.1: ncu-ci citgm 2799 2800FAILURE: 5 failures in 2800 not present in 2799
┌────────────────────────┬─────────────────────────┐
│ (index) │ 0 │
├────────────────────────┼─────────────────────────┤
│ fedora-last-latest-x64 │ 'socket.io-v4.4.0' │
│ debian10-x64 │ │
│ win-vs2019 │ │
│ fedora-latest-x64 │ │
│ debian9-64 │ │
│ aix71-ppc64 │ │
│ osx1015 │ 'async-v3.2.2' │
│ rhel7-s390x │ │
│ osx1014 │ 'torrent-stream-v1.2.1' │
│ ubuntu1604-64 │ 'socket.io-v4.4.0' │
│ win-vs2017 │ │
│ centos7-ppcle │ 'multer-v1.4.3' │
│ ubuntu1804-64 │ │
└────────────────────────┴─────────────────────────┘ncu-ci citgm 2801 2802FAILURE: 7 failures in 2802 not present in 2801
┌────────────────────────┬───────────────────────────┬─────────────────────┬─────────────────────────┐
│ (index) │ 0 │ 1 │ 2 │
├────────────────────────┼───────────────────────────┼─────────────────────┼─────────────────────────┤
│ ubuntu1604-64 │ 'torrent-stream-v1.2.1' │ │ │
│ centos7-ppcle │ 'express-session-v1.17.2' │ 'spawn-wrap-v2.0.0' │ 'torrent-stream-v1.2.1' │
│ debian10-x64 │ │ │ │
│ aix71-ppc64 │ │ │ │
│ fedora-last-latest-x64 │ │ │ │
│ win-vs2019 │ │ │ │
│ ubuntu1804-64 │ │ │ │
│ rhel7-s390x │ │ │ │
│ osx1014 │ 'fastify-v3.24.0' │ │ │
│ osx1015 │ 'socket.io-v4.4.0' │ │ │
│ win-vs2017 │ │ │ │
│ debian9-64 │ 'pump-v3.0.0' │ │ │
│ fedora-latest-x64 │ │ │ │
└────────────────────────┴───────────────────────────┴─────────────────────┴─────────────────────────┘Release build on c3dd76a: https://ci-release.nodejs.org/job/iojs+release/8106/ |
27 tasks
VoltrexKeyva
removed
doc
VoltrexKeyva
added
release
This was referenced Nov 28, 2021
targos
approved these changes
Nov 29, 2021
richardlau
added a commit
that referenced
this pull request
Nov 30, 2021
Notable changes This release contains a c-ares update to fix a regression introduced in Node.js 14.17.5 resolving CNAME records containing underscores (#39780). Also included are commits to allow Node.js 14 to continue to build and pass tests on our Jenkins CI, including adding Python 3.10 to the list of allowable Python versions for building. PR-URL: #40969
richardlau
added a commit
to richardlau/nodejs.org
that referenced
this pull request
Nov 30, 2021
richardlau
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Nov 30, 2021
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Notable changes This release contains a c-ares update to fix a regression introduced in Node.js 14.17.5 resolving CNAME records containing underscores (nodejs#39780). Also included are commits to allow Node.js 14 to continue to build and pass tests on our Jenkins CI, including adding Python 3.10 to the list of allowable Python versions for building. PR-URL: nodejs#40969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-11-30, Version 14.18.2 'Fermium' (LTS), @richardlau
Notable changes
This release contains a c-ares update to fix a regression introduced in
Node.js 14.17.5 resolving CNAME records containing underscores
#39780.
Also included are commits to allow Node.js 14 to continue to build and
pass tests on our Jenkins CI, including adding Python 3.10 to the list
of allowable Python versions for building.
Commits
7923c61a62] - build: pin build-docs workflow to Node.js 14 (Richard Lau) #40939da356128fb] - build: support Python 3.10.0 (FrankQiu) #402969c3a85d279] - deps: update c-ares to 1.18.1 (Richard Lau) #40660cd7c340545] - deps: V8: patch jinja2 for Python 3.10 compat (Michaël Zasso) #402966330d435f5] - doc: mark Node.js 10 as End-of-Life (Richard Lau) #384828ca082ec71] - doc: fix CJS-ESM selector in Safari (Bradley Farias) #4013592490d1c89] - doc: add macOS arm64 experimental status (Michael Rienstra) #401278894bdd4d8] - lib: fix regular expression to detect `/` and `\` (Francesco Trotta) #40325704989b698] - test: deflake child-process-pipe-dataflow (Luigi Pinca) #40838df401cd346] - test: update upload.zip to be uncorrupted (Greg Ziskind) #37294aa947f7dbf] - tools: add script to update c-ares (Richard Lau) #406606b7b2bba41] - tools: patch jinja2 for Python 3.10 compat (Michaël Zasso) #4029639583f77d8] - worker: avoid potential deadlock on NearHeapLimit (Santiago Gimeno) #38403