build: improve readability of texts in workflows #40988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
lpinca
reviewed
Nov 27, 2021
targos
reviewed
Dec 15, 2021
targos
approved these changes
Dec 15, 2021
Mesteery
added
the
author ready
jasnell
approved these changes
Dec 17, 2021
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40988 ✔ Done loading data for nodejs/node/pull/40988 ----------------------------------- PR info ------------------------------------ Title build: improve readability of texts in workflows (#40988) Author Mestery (@Mesteery) Branch Mesteery:actions-text-lisibility -> nodejs:master Labels meta, author ready, commit-queue-squash Commits 6 - build: improve readability of texts in workflows - Update close-stalled.yml - Merge branch 'master' into actions-text-lisibility - Update comment-labeled.yml - Update close-stalled.yml - Update comment-labeled.yml Committers 2 - Mestery - GitHub PR-URL: https://github.com/nodejs/node/pull/40988 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40988 Reviewed-By: Michaël Zasso Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 26 Nov 2021 21:42:25 GMT ✔ Approvals: 2 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40988#pullrequestreview-832411116 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40988#pullrequestreview-835355041 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 40988 From https://github.com/nodejs/node * branch refs/pull/40988/merge -> FETCH_HEAD ✔ Fetched commits as c8f5dd64b157..3214e0eb5536 -------------------------------------------------------------------------------- Auto-merging .github/workflows/authors.yml Auto-merging .github/workflows/close-stalled.yml Auto-merging .github/workflows/comment-labeled.yml CONFLICT (content): Merge conflict in .github/workflows/comment-labeled.yml Auto-merging .github/workflows/license-builder.yml error: could not apply cc3df1d1c3... build: improve readability of texts in workflows hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ✖ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/1593003553 |
nodejs-github-bot
added
the
commit-queue-failed
|
@Mesteery I think this fails to land automatically because of the merge commit. |
Mesteery
force-pushed
the
actions-text-lisibility
branch
from
3214e0e to
d3419ae
Compare
Mesteery
removed
the
commit-queue-squash
jasnell
removed
the
commit-queue-failed
jasnell
approved these changes
Dec 19, 2021
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 665b404 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #40988 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #40988 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#40988 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40988 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.