test: skip ESLint tests if no Intl #41105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint dependency now requires Intl because it uses regexp unicode character properties. Fixes: nodejs#41102
Trott
added
fast-track
|
Seeking fast-tracking because this fixes CI. |
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Dec 7, 2021
targos
approved these changes
Dec 7, 2021
Closed
DerekNonGeneric
approved these changes
Dec 7, 2021
Trott
added
the
author ready
richardlau
approved these changes
Dec 7, 2021
BridgeAR
approved these changes
Dec 7, 2021
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e60801a |
This was referenced Dec 8, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
ESLint dependency now requires Intl because it uses regexp unicode character properties. Fixes: #41102 PR-URL: #41105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
ESLint dependency now requires Intl because it uses regexp unicode character properties. Fixes: #41102 PR-URL: #41105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
ESLint dependency now requires Intl because it uses regexp unicode character properties. Fixes: #41102 PR-URL: #41105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
ESLint dependency now requires Intl because it uses regexp unicode character properties. Fixes: #41102 PR-URL: #41105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
ESLint dependency now requires Intl because it uses regexp unicode character properties. Fixes: nodejs#41102 PR-URL: nodejs#41105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
ESLint dependency now requires Intl because it uses regexp unicode character properties. Fixes: #41102 PR-URL: #41105 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint dependency now requires Intl because it uses regexp unicode
character properties.
Fixes: #41102