-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update doc dependency mdast-util-gfm-table to 1.0.2 #41260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that causes our tooling to generate invalid HTML. (The `align` attribute on `tr` and `td` elements was ending up with the invalid value of `"none"`.) Refs: remarkjs/remark-gfm#29 Refs: syntax-tree/mdast-util-gfm-table@a28b860
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
tools
Issues and PRs related to the tools directory.
labels
Dec 21, 2021
targos
approved these changes
Dec 21, 2021
cjihrig
approved these changes
Dec 21, 2021
Trott
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 21, 2021
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 21, 2021
jasnell
approved these changes
Dec 21, 2021
Fast-track has been requested by @jasnell. Please 👍 to approve. |
lpinca
approved these changes
Dec 22, 2021
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 22, 2021
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 23, 2021
Landed in 1c6d81e |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The `align` attribute on `tr` and `td` elements was ending up with the invalid value of `"none"`.) Refs: remarkjs/remark-gfm#29 Refs: syntax-tree/mdast-util-gfm-table@a28b860 PR-URL: #41260 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The `align` attribute on `tr` and `td` elements was ending up with the invalid value of `"none"`.) Refs: remarkjs/remark-gfm#29 Refs: syntax-tree/mdast-util-gfm-table@a28b860 PR-URL: #41260 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The `align` attribute on `tr` and `td` elements was ending up with the invalid value of `"none"`.) Refs: remarkjs/remark-gfm#29 Refs: syntax-tree/mdast-util-gfm-table@a28b860 PR-URL: nodejs#41260 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The `align` attribute on `tr` and `td` elements was ending up with the invalid value of `"none"`.) Refs: remarkjs/remark-gfm#29 Refs: syntax-tree/mdast-util-gfm-table@a28b860 PR-URL: #41260 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that causes our tooling to generate invalid HTML. (The
align
attribute ontr
andtd
elements was ending up with theinvalid value of
"none"
.)Refs: remarkjs/remark-gfm#29
Refs: syntax-tree/mdast-util-gfm-table@a28b860