meta: update node-api team name #41268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.
richardlau
force-pushed
the
ode-to-team
branch
from
bd9afab to
e889d11
Compare
richardlau
changed the title
NickNaso
reviewed
Dec 21, 2021
NickNaso
approved these changes
Dec 21, 2021
Co-authored-by: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
richardlau
added
the
commit-queue-squash
cjihrig
approved these changes
Dec 21, 2021
richardlau
added
the
author ready
addaleax
approved these changes
Dec 21, 2021
tniessen
approved these changes
Dec 21, 2021
lpinca
approved these changes
Dec 22, 2021
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/41268 ✔ Done loading data for nodejs/node/pull/41268 ----------------------------------- PR info ------------------------------------ Title meta: update node-api team name (#41268) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:ode-to-team -> nodejs:master Labels meta, author ready, commit-queue-squash Commits 2 - meta: update node-api team name - fixup! meta: update node-api team name Committers 2 - Richard Lau - GitHub PR-URL: https://github.com/nodejs/node/pull/41268 Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41268 Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 21 Dec 2021 19:20:48 GMT ✔ Approvals: 5 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41268#pullrequestreview-837843751 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41268#pullrequestreview-837867874 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41268#pullrequestreview-837873680 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41268#pullrequestreview-837925525 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41268#pullrequestreview-838793934 ✖ This PR needs to wait 2 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1616345446 |
nodejs-github-bot
added
the
commit-queue-failed
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 406e6d8 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`. PR-URL: #41268 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`. PR-URL: #41268 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`. PR-URL: nodejs#41268 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`. PR-URL: #41268 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@nodejs/n-apiteam was renamed to@nodejs/node-api.cc @nodejs/node-api