Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove conditional assignment in custom ESLint rule #41325

Merged
merged 1 commit into from
Jan 5, 2022
Merged

tools: remove conditional assignment in custom ESLint rule #41325

merged 1 commit into from
Jan 5, 2022
+10 −9

Commits on Jan 5, 2022

  1. tools: remove conditional assignment in custom ESLint rule 

    These changes no-duplicate-require.js so that it doesn't use an
assignment in a conditional, which can be easy to misread as a
comparison rather than an assignment. It also means we change a do/while
(which we don't use much in our code) to the much more common while
construct.

PR-URL: nodejs#41325
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @Trott
    Trott committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    e7d4e6b View commit details
    Browse the repository at this point in the history