Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document that require.main may be undefined #41384

Merged
merged 2 commits into from
Jan 5, 2022
Merged

doc: document that require.main may be undefined #41384

merged 2 commits into from
Jan 5, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 2, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Jan 2, 2022
@aduh95 aduh95 added doc Issues and PRs related to the documentations. and removed doc Issues and PRs related to the documentations. labels Jan 2, 2022
tniessen
tniessen reviewed Jan 3, 2022
View reviewed changes
doc/api/modules.md Outdated Show resolved Hide resolved
edsadr
edsadr approved these changes Jan 3, 2022
View reviewed changes
doc/api/modules.md Outdated Show resolved Hide resolved
aduh95
aduh95 commented Jan 3, 2022
View reviewed changes
doc/api/modules.md Outdated Show resolved Hide resolved
@tniessen
Copy link
Member

tniessen commented Jan 3, 2022

Thanks for updating it @aduh95! :)

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 3, 2022
@sindresorhus sindresorhus mentioned this pull request Jan 4, 2022
Closed
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit 090cdb6 into nodejs:master Jan 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 090cdb6

@aduh95 aduh95 deleted the require-main-undefined branch January 5, 2022 10:56
targos pushed a commit that referenced this pull request Jan 14, 2022
@aduh95 @targos
doc: document that require.main may be undefined
16c0bea 
PR-URL: #41384
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@aduh95 @danielleadams
doc: document that require.main may be undefined
c0bdefb 
PR-URL: #41384
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@aduh95 @Linkgoron
doc: document that require.main may be undefined
5b2bf8c 
PR-URL: nodejs#41384
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@aduh95 @danielleadams
doc: document that require.main may be undefined
04a81b3 
PR-URL: #41384
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@tniessen tniessen tniessen approved these changes

@targos targos targos approved these changes

@antsmartian antsmartian antsmartian approved these changes

@edsadr edsadr edsadr approved these changes

@guybedford guybedford guybedford approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @nodejs-github-bot @tniessen @ljharb @GeoffreyBooth @guybedford @edsadr @antsmartian @targos