Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use GetCurrentProcessId() for process.pid #4163

Merged
merged 1 commit into from
Dec 5, 2015
Merged

src: use GetCurrentProcessId() for process.pid #4163

merged 1 commit into from
Dec 5, 2015

Commits on Dec 5, 2015

  1. src: use GetCurrentProcessId() for process.pid 

    Commit a9c0c65 ("src: define getpid() based on OS") made src/env.cc
use `GetCurrentProcessId()` on Windows for the PID in log messages.
`GetCurrentProcessId()` is also what is used by libuv, OpenSSL and V8.

This commit makes `process.pid` use `GetCurrentProcessId()` instead of
`_getpid()` for consistency.

PR-URL: nodejs#4163
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed Dec 5, 2015
    Configuration menu
    Copy the full SHA
    e6e7891 View commit details
    Browse the repository at this point in the history