test: remove unneeded test statement #41663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The statement removed was added in 6657b15 but it was not added as an assertion. It currently returns false but t0he test does not fail because of the missing assertion. Since the property is no longer one that exists, there is no need to test its existence. Remove the line.
nodejs-github-bot
added
needs-ci
benjamingr
approved these changes
Jan 23, 2022
Mesteery
approved these changes
Jan 23, 2022
RaisinTen
approved these changes
Jan 23, 2022
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jan 23, 2022
22 tasks
bnb
approved these changes
Jan 24, 2022
28 tasks
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ff5766f |
This was referenced Jan 26, 2022
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
The statement removed was added in 6657b15 but it was not added as an assertion. It currently returns false but t0he test does not fail because of the missing assertion. Since the property is no longer one that exists, there is no need to test its existence. Remove the line. PR-URL: nodejs#41663 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
The statement removed was added in 6657b15 but it was not added as an assertion. It currently returns false but t0he test does not fail because of the missing assertion. Since the property is no longer one that exists, there is no need to test its existence. Remove the line. PR-URL: #41663 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
The statement removed was added in 6657b15 but it was not added as an assertion. It currently returns false but t0he test does not fail because of the missing assertion. Since the property is no longer one that exists, there is no need to test its existence. Remove the line. PR-URL: #41663 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
The statement removed was added in 6657b15 but it was not added as an assertion. It currently returns false but t0he test does not fail because of the missing assertion. Since the property is no longer one that exists, there is no need to test its existence. Remove the line. PR-URL: #41663 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
The statement removed was added in 6657b15 but it was not added as an assertion. It currently returns false but t0he test does not fail because of the missing assertion. Since the property is no longer one that exists, there is no need to test its existence. Remove the line. PR-URL: #41663 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statement removed was added in 6657b15 but it was not added
as an assertion. It currently returns false but t0he test does not fail
because of the missing assertion. Since the property is no longer one
that exists, there is no need to test its existence. Remove the line.