Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify treatment of non-string base in URL() #41685

Merged
merged 1 commit into from
Jan 27, 2022
Merged

doc: clarify treatment of non-string base in URL() #41685

merged 1 commit into from
Jan 27, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 25, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Jan 25, 2022
RaisinTen
RaisinTen approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a reference to #41653 in the pr description?

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit c15639d into nodejs:master Jan 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in c15639d

@Trott Trott deleted the baskets branch January 27, 2022 05:50
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
doc: clarify treatment of non-string base in URL()
9bbdacd 
PR-URL: nodejs#41685
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@Trott @ruyadorno
doc: clarify treatment of non-string base in URL()
ae34900 
PR-URL: #41685
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
doc: clarify treatment of non-string base in URL()
72aa86f 
PR-URL: #41685
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
doc: clarify treatment of non-string base in URL()
a5e9ca4 
PR-URL: #41685
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
doc: clarify treatment of non-string base in URL()
018ec32 
PR-URL: #41685
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @RaisinTen @VoltrexKeyva